[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Drop UML driver



On 12/14/18 3:35 PM, Daniel P. Berrangé wrote:
> On Fri, Dec 14, 2018 at 03:30:17PM +0100, Michal Privoznik wrote:
>> The driver is unmaintained, untested and severely broken for
>> quite some time now. Since nobody even reported any issue with it
>> let us drop it.
>>
>> Signed-off-by: Michal Privoznik <mprivozn redhat com>
>> ---
> 
>>  docs/schemas/capability.rng          |    2 -
>>  docs/schemas/domaincommon.rng        |    3 -
> 
> 
>>  src/conf/domain_conf.c               |   11 +-
>>  src/conf/domain_conf.h               |    4 -
> 
> We shouldn't be deleting stuff from the XML schemas. IMHO the schemas
> are an append only source object. If some parts happen to not be used
> by current code that's fine, but they are a record of the ABI promise
> of the schema.

So we should be able to validate <domain type="uml"/> even though there
is no longer any driver that would define such domain? I don't see much
point in that.

Also, removing a driver is breaking the ABI promise.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]