[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] tests: Return failures immediately in virErrorTestMsgs



On Mon, Dec 17, 2018 at 09:55:46 -0500, John Ferlan wrote:
> Rather than chancing calling strchr when @err_noinfo == NULL or
> calling virErrorTestMsgFormatInfoOne when @err_info == NULL, both
> of which would fail, let's just return -1 immediately when we
> encounter an error.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  tests/virerrortest.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

This would make the test hard to diagnose as it spits out one failure at
time. I prefer you add the checks explicitly.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]