[libvirt] [PATCH v2] qemu: Expose rx/tx_queue_size in qemu.conf too

John Ferlan jferlan at redhat.com
Thu Feb 1 14:58:17 UTC 2018



On 02/01/2018 09:04 AM, Michal Privoznik wrote:
> In 2074ef6cd4a2 and c56cdf259 (and friends) we've added two
> attributes to virtio NICs: rx_queue_size and tx_queue_size.
> However, sysadmins might want to set these on per-host basis but
> don't necessarily have an access to domain XML (e.g. because they
> are generated by some other app). So let's expose them under
> qemu.conf (the settings from domain XML still take precedence as
> they are more specific ones).
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> diff to v1:
> - Reworded docs and config file comment
> - Simplified logic in qemuBuildNicDevStr a bit
> - Make the values require qemu with corresponding capabilities
> 
>  docs/formatdomain.html.in          | 14 ++++++++--
>  src/qemu/libvirtd_qemu.aug         |  4 +++
>  src/qemu/qemu.conf                 |  6 +++++
>  src/qemu/qemu_command.c            | 55 +++++++++++++++++++++++++++-----------
>  src/qemu/qemu_command.h            |  3 ++-
>  src/qemu/qemu_conf.c               |  4 +++
>  src/qemu/qemu_conf.h               |  3 +++
>  src/qemu/qemu_hotplug.c            |  2 +-
>  src/qemu/test_libvirtd_qemu.aug.in |  2 ++
>  9 files changed, 74 insertions(+), 19 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list