[libvirt] [tck PATCH 0/9] Fix libvirt-tck nwfilter tests

[Laine Stump]

libvirt-tck happens to have the most thorough set of nwfilter tests
around. Unfortunately they haven't been run in quite awhile, and have
suffered from some bit rot. This patch series (along with Dan's patch
to force virt-builder to redo selinux labels after installing extra
packages) gets the nwfilter tests all completing successfully again
*on a Fedora 26 host* with libvirt 3.2.1 and libvirt 4.0.0+.

The concurrency tests (at least) still fail on an F27 host - in that
case they are actually revealing a bug due to something in libvirt,
libpcap, or maybe the kernel (and since the kernels in F26 and F27 are
nearly the same, and I tried both of the above libvirt versions on F27
with the same failure (two threads hung in a polling loop in libpcap)

Once I got this all running, I noticed that there are several domain
and network tests that are failing, and at least the ones I looked
into were due to bugs in the tests (e.g. the netdev hotplug test uses
multicast MAC addresses, and assumes that device detaches are
synchronous), so there's more work to do, but the nwfilter tests are
what's most important right now.

Laine Stump (9):
  create vms that use virt-builder images with no graphics and
    virtio-net
  Use $net->get_dhcp_leases() when available
  Use Net::OpenSSH instead of Net::SSH::Perl
  Fix no-ip-spoofing test script generation
  Fix no-arp-spoof test script generation
  parameterize filterref in generic_domain
  Fix ebtables check in no-mac-broadcast test
  filter for proper IP address in tcpdump looking for broadcast packet
  Eliminate unnecessary path specifications in binary names

 lib/Sys/Virt/TCK.pm                       | 22 +++++-------
 lib/Sys/Virt/TCK/NetworkHelpers.pm        |  9 +++++
 perl-Sys-Virt-TCK.spec.PL                 |  3 +-
 scripts/nwfilter/100-ping-still-working.t |  6 ++--
 scripts/nwfilter/210-no-mac-spoofing.t    | 52 ++++++++++++++-------------
 scripts/nwfilter/220-no-ip-spoofing.t     | 59 ++++++++++++++++---------------
 scripts/nwfilter/230-no-mac-broadcast.t   | 39 ++++++++++----------
 scripts/nwfilter/240-no-arp-spoofing.t    | 36 ++++++++++---------
 scripts/nwfilter/300-vsitype.t            |  1 -
 scripts/nwfilter/nwfilter_concurrent.sh   |  4 +--
 10 files changed, 121 insertions(+), 110 deletions(-)

-- 
2.13.6