[libvirt] [PATCH] qemu: command: Extract formatting of floppy related stuff into a helper

Ján Tomko jtomko at redhat.com
Fri Feb 9 15:43:45 UTC 2018


On Thu, Feb 08, 2018 at 03:25:25PM +0100, Peter Krempa wrote:
>The floppy command formatting is special-cased since it does not
>directly translate to a single '-device' argument.
>
>Move the code from qemuBuildDiskDriveCommandLine to a new helper
>function so that all the related code is together.

Please ask the author of the patch to provide a Signed-off-by line to
conform with our contributor guidelines, point 6:
https://libvirt.org/hacking.html#patches

A sign-off a day keeps lawyers away.

>---
> src/qemu/qemu_command.c | 91 +++++++++++++++++++++++++++++--------------------
> 1 file changed, 54 insertions(+), 37 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180209/8b71c3d3/attachment-0001.sig>


More information about the libvir-list mailing list