[libvirt] [PATCH v2 00/14] Enforce presence of all switch enum cases

Daniel P. Berrangé berrange at redhat.com
Tue Feb 20 17:08:08 UTC 2018


This is the same as the previous series, but with standardized error
reporting macro to get consistent error messages.

This is just the first part of the previous series. The second part is
much more work to convert to this new error reporting macro, so i'll
drip-feed the rest for review over next few days...

Daniel P. Berrangé (14):
  util: add a virReportEnumRangeError for bad value reporting
  util: handle missing switch enum cases
  conf: handle missing switch enum cases
  esx: handle missing switch enum cases
  hyperv: handle missing switch enum cases
  libxl: handle missing switch enum cases
  lxc: handle missing switch enum cases
  nwfilter: handle missing switch enum cases
  qemu: handle missing switch enum cases
  rpc: handle missing switch enum cases
  security: handle missing switch enum cases
  xen: handle missing switch enum cases
  tools: handle missing switch enum cases
  m4: enforce that all enum cases are listed in switch statements

 m4/virt-compile-warnings.m4               |  7 +++--
 src/conf/domain_audit.c                   |  1 +
 src/conf/domain_conf.c                    | 46 +++++++++++++++++++++++++++----
 src/conf/nwfilter_conf.c                  | 31 ++++++++++++++++++++-
 src/conf/nwfilter_conf.h                  |  4 +--
 src/esx/esx_driver.c                      |  1 +
 src/esx/esx_vi.c                          | 11 +++++---
 src/esx/esx_vi_types.c                    |  9 +++---
 src/hyperv/hyperv_driver.c                | 18 ++++++++++--
 src/libxl/libxl_driver.c                  |  2 +-
 src/lxc/lxc_container.c                   |  8 +++---
 src/lxc/lxc_controller.c                  |  8 +++++-
 src/lxc/lxc_driver.c                      | 38 ++++++++++++++++++++++---
 src/nwfilter/nwfilter_ebiptables_driver.c | 17 ++++++++----
 src/nwfilter/nwfilter_learnipaddr.c       |  6 +++-
 src/qemu/qemu_command.c                   | 26 +++++++++++------
 src/qemu/qemu_domain.c                    | 21 ++++++++++++++
 src/qemu/qemu_driver.c                    | 25 +++++++++++------
 src/qemu/qemu_hotplug.c                   | 33 ++++++++++++++++++----
 src/qemu/qemu_migration.c                 | 11 +++++++-
 src/qemu/qemu_process.c                   |  2 ++
 src/rpc/virnetclient.c                    |  2 ++
 src/rpc/virnetclientprogram.c             |  1 +
 src/rpc/virnetserverprogram.c             |  4 +++
 src/security/security_driver.c            |  1 +
 src/util/virconf.c                        | 11 +++++++-
 src/util/virerror.h                       |  9 +++++-
 src/util/virfirewall.c                    |  6 ++--
 src/util/virlog.c                         |  9 +++++-
 src/util/virnetdevvportprofile.c          | 10 ++++++-
 src/vmx/vmx.c                             | 26 +++++++++++++++--
 src/xenconfig/xen_common.c                | 18 ++++++++++--
 src/xenconfig/xen_xl.c                    |  7 ++++-
 tools/virt-host-validate-qemu.c           |  3 +-
 34 files changed, 359 insertions(+), 73 deletions(-)

-- 
2.14.3




More information about the libvir-list mailing list