[libvirt] [PATCH 3/3] qemu: Add virConnectPtr back to some migration methods

Daniel P. Berrangé berrange at redhat.com
Mon Feb 26 10:08:10 UTC 2018


On Mon, Feb 26, 2018 at 11:05:51AM +0100, Michal Privoznik wrote:
> This partially reverts 82592551cb8c4112cfa2264d50b8dce5349533d5.
> 
> When migrating a domain, qemuMigrationDstPrepareAny() is called
> which eventually calls qemuProcessLaunch(conn = NULL, flags =
> VIR_QEMU_PROCESS_START_AUTODESTROY); But the very first thing
> that qemuProcessLaunch does is check if AUTODESTROY flag is set
> and @conn is not NULL. Well, it is.

Doh, I was over zealous removing it then :-)

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_driver.c    | 12 ++++++------
>  src/qemu/qemu_migration.c | 17 ++++++++++-------
>  src/qemu/qemu_migration.h |  2 ++
>  3 files changed, 18 insertions(+), 13 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list