[libvirt] [PATCH] storage: fix sheepdog driver / test linking to avoid duplicating source

Michal Privoznik mprivozn at redhat.com
Tue Feb 27 13:33:15 UTC 2018


On 02/27/2018 12:30 PM, Daniel P. Berrangé wrote:
> The libvirt_storage_backend_sheepdog_priv.la library depends on symbols
> provided in the libvirt_driver_storage_impl.la library. As such the
> latter must be listed 2nd when passed to the linker to avoid symbol
> resolution problems. This mistake is being masked by the sheepdog
> driver linking in a second copy of the storage driver code. Remove
> this duplicate linkage of backend source and fix the test link order.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/Makefile.am   | 3 +--
>  tests/Makefile.am | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)

ACK and safe for freeze.

Michal




More information about the libvir-list mailing list