[libvirt] [PATCH v3 6/6] tests: add test case for CPUID in xenconfig driver

[Jim Fehlig]

On 12/09/2017 07:10 PM, Marek Marczykowski-Górecki wrote:
> Check conversion of "cpuid" setting, check all supported policy settings
> ("1", "0", "x"). Also, check interaction with "nestedhvm" - should not
> be included as "vmx=1" in "cpuid" setting.
> 
> ---
> Changes since v2:
>   - new patch
> ---
>   tests/xlconfigdata/test-fullvirt-cpuid.cfg | 25 ++++++++++++++++-
>   tests/xlconfigdata/test-fullvirt-cpuid.xml | 36 +++++++++++++++++++++++-
>   tests/xlconfigtest.c                       |  1 +-
>   3 files changed, 62 insertions(+)
>   create mode 100644 tests/xlconfigdata/test-fullvirt-cpuid.cfg
>   create mode 100644 tests/xlconfigdata/test-fullvirt-cpuid.xml

Reviewed-by: Jim Fehlig <jfehlig at suse.com>

Regards,
Jim

> 
> diff --git a/tests/xlconfigdata/test-fullvirt-cpuid.cfg b/tests/xlconfigdata/test-fullvirt-cpuid.cfg
> new file mode 100644
> index 0000000..bb7b9c7
> --- /dev/null
> +++ b/tests/xlconfigdata/test-fullvirt-cpuid.cfg
> @@ -0,0 +1,25 @@
> +name = "XenGuest2"
> +uuid = "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
> +maxmem = 579
> +memory = 394
> +vcpus = 1
> +pae = 1
> +acpi = 0
> +apic = 0
> +viridian = 0
> +rtc_timeoffset = 0
> +localtime = 0
> +on_poweroff = "destroy"
> +on_reboot = "restart"
> +on_crash = "restart"
> +device_model = "/usr/lib/xen/bin/qemu-system-i386"
> +sdl = 0
> +vnc = 1
> +vncunused = 1
> +vnclisten = "127.0.0.1"
> +parallel = "none"
> +serial = "none"
> +builder = "hvm"
> +boot = "d"
> +nestedhvm = 1
> +cpuid = "host,tm=0,sse3=1,page1gb=x"
> diff --git a/tests/xlconfigdata/test-fullvirt-cpuid.xml b/tests/xlconfigdata/test-fullvirt-cpuid.xml
> new file mode 100644
> index 0000000..277b419
> --- /dev/null
> +++ b/tests/xlconfigdata/test-fullvirt-cpuid.xml
> @@ -0,0 +1,36 @@
> +<domain type='xen'>
> +  <name>XenGuest2</name>
> +  <uuid>c7a5fdb2-cdaf-9455-926a-d65c16db1809</uuid>
> +  <memory unit='KiB'>592896</memory>
> +  <currentMemory unit='KiB'>403456</currentMemory>
> +  <vcpu placement='static'>1</vcpu>
> +  <os>
> +    <type arch='x86_64' machine='xenfv'>hvm</type>
> +    <loader type='rom'>/usr/lib/xen/boot/hvmloader</loader>
> +    <boot dev='cdrom'/>
> +  </os>
> +  <features>
> +    <pae/>
> +  </features>
> +  <cpu mode='host-passthrough'>
> +    <feature policy='force' name='vmx'/>
> +    <feature policy='disable' name='tm'/>
> +    <feature policy='force' name='pni'/>
> +    <feature policy='optional' name='pdpe1gb'/>
> +  </cpu>
> +  <clock offset='variable' adjustment='0' basis='utc'/>
> +  <on_poweroff>destroy</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>restart</on_crash>
> +  <devices>
> +    <emulator>/usr/lib/xen/bin/qemu-system-i386</emulator>
> +    <input type='mouse' bus='ps2'/>
> +    <input type='keyboard' bus='ps2'/>
> +    <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'>
> +      <listen type='address' address='127.0.0.1'/>
> +    </graphics>
> +    <video>
> +      <model type='cirrus' vram='8192' heads='1' primary='yes'/>
> +    </video>
> +  </devices>
> +</domain>
> diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c
> index 57a0a67..39f51e2 100644
> --- a/tests/xlconfigtest.c
> +++ b/tests/xlconfigtest.c
> @@ -270,6 +270,7 @@ mymain(void)
>       DO_TEST("fullvirt-multi-timer");
>       DO_TEST("fullvirt-nestedhvm");
>       DO_TEST("fullvirt-nestedhvm-disabled");
> +    DO_TEST("fullvirt-cpuid");
>   #ifdef LIBXL_HAVE_VNUMA
>       DO_TEST("fullvirt-vnuma");
>       DO_TEST_PARSE("fullvirt-vnuma-autocomplete", false);
>