[libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

[Jiri Denemark]

On Tue, Jan 09, 2018 at 15:32:54 +0100, Kashyap Chamarthy wrote:
> The 'check' attribute is referring to this:
> 
>     <cpu mode='custom' match='exact' check='full'>
> 
> Upstream documentation says, it is:
> 
>     used to request a specific way of checking whether the virtual CPU
>     matches the specification. It is usually safe to omit this attribute
>     when starting a domain and stick with the default value.
> 
> But doesn't tell *what* the default value is.  It is check='partial'.
> Mention it so.
> 
> Thanks: Jiri Denemark
> ---
>  docs/formatdomain.html.in | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

NACK

As I said on IRC, the default differs with guest architecture ('partial'
for x86_64, 'none' for all others). Moreover this only applies to QEMU
driver. Oh and it even changes based on the mode attribute to make not
make it easy. But this is really an implementation detail. Libvirt will
just use a suitable default to stay compatible with older releases.

Jirka