[libvirt] [PATCH] qemu: Don't initialize struct utsname
Daniel P. Berrange
berrange at redhat.com
Mon Jan 22 14:01:26 UTC 2018
On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote:
> It breaks the build and it is not really useful for anything.
Why does that break the build ? "{ 0 }" is a valid initializer for
any struct according to the C standards.
>
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>
> Pushed under the build breaker rule.
>
> src/qemu/qemu_capabilities.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 2c573827f1..5e03447baa 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -5431,7 +5431,7 @@ virQEMUCapsCacheNew(const char *libDir,
> char *capsCacheDir = NULL;
> virFileCachePtr cache = NULL;
> virQEMUCapsCachePrivPtr priv = NULL;
> - struct utsname uts = { 0 };
> + struct utsname uts;
>
> if (virAsprintf(&capsCacheDir, "%s/capabilities", cacheDir) < 0)
> goto error;
> --
> 2.16.0
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list