[libvirt] [PATCH 4/4] qemu: block: Add support for RBD authentication for blockdev

[Peter Krempa]

On Mon, Jul 09, 2018 at 23:59:30 +0800, Han Han wrote:

Please don't top-post on technical lists.

> It seems resolved https://bugzilla.redhat.com/show_bug.cgi?id=1596511 . If
> so, please add this link in commit msg.

1) There is no public data for that bugzilla everything is private so
there's not much use in adding that link for upstream reference.

2) That bugzilla is in my opinion invalid.  The RBD formatting code is
not used currently and the only reason why this code was already
committed is so that I don't have to post everything at once when I
finish all the relevant parts for -blockdev. This means that there
currently is no bug or lack of feature in upstream which could be
tracked and when enabling -blockdev everything will work properly.

I could live with adding that despite '2)' but as it's totally pointless
due to '1)'. You can improve the public part of that bugzilla since
you've filed it though and then I'll reconsider.

> 
> On Mon, Jul 9, 2018 at 10:12 PM, Peter Krempa <pkrempa at redhat.com> wrote:
> 
> > To allow using -blockdev with RBD we need to support the recently added
> > RBD authentication.
> >
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180709/8f9a6ffc/attachment-0001.sig>