[libvirt] [PATCH] storage_util: Prefer generic FICLONE over btrfs/xfs defines

Andrea Bolognani abologna at redhat.com
Tue Jul 10 08:47:54 UTC 2018


On Mon, 2018-07-09 at 16:59 +0200, Michal Privoznik wrote:
> After my change to the original patch that resulted in commit
> 8ed874b39b3 it was brought to my attention that all three defines
> are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE.

I'd mention that this is documented in ioctl_ficlone(2), just
for completeness' sake.

It's pretty weird that *_IOC_CLONE have not been redefined in
terms of FICLONE once the latter had been introduced. Oh well.

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list