[libvirt] [PATCH 03/13] conf: Introduce a new PCI address extension flag

Ján Tomko jtomko at redhat.com
Sat Jun 2 14:15:54 UTC 2018


On Thu, May 24, 2018 at 02:24:28PM +0200, Xiao Feng Ren wrote:
>From: Yi Min Zhao <zyimin at linux.ibm.com>
>
>This patch introduces a new attribute PCI address extension flag
>to deal with the extension PCI attributes such as 'uid' and 'fid'
>on the S390 platform.
>
>Signed-off-by: Yi Min Zhao <zyimin at linux.ibm.com>
>Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>---
> src/conf/device_conf.h         |   1 +
> src/conf/domain_addr.h         |   5 ++
> src/qemu/qemu_domain_address.c | 137 ++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 141 insertions(+), 2 deletions(-)
>

>diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
>index b7c82cb6f1..adce399be6 100644
>--- a/src/qemu/qemu_domain_address.c
>+++ b/src/qemu/qemu_domain_address.c
>@@ -502,6 +502,60 @@ qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def,
> }
>
>
>+static bool
>+qemuDomainDeviceSupportZPCI(virQEMUCapsPtr qemuCaps,
>+                            virDomainDeviceDefPtr device)
>+{
>+    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI))
>+        return false;

There's no need to propagate qemuCaps all the way here,
if we don't have QEMU_CAPS_DEVICE_ZPCI, we don't care which devices
support it.

>+
>+    switch ((virDomainDeviceType) device->type) {
>+    case VIR_DOMAIN_DEVICE_CONTROLLER:
>+    case VIR_DOMAIN_DEVICE_CHR:
>+        return false;

Are these going to support it later? How will we detect that?

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180602/f0906a4d/attachment-0001.sig>


More information about the libvir-list mailing list