[libvirt] [PATCH] storage: minor fix in luks encrypted volume creation

[Andrea Bolognani]

On Wed, 2018-06-06 at 18:19 +0200, Ján Tomko wrote:
> On Wed, Jun 06, 2018 at 05:41:58PM +0200, Andrea Bolognani wrote:
> > On Wed, 2018-06-06 at 17:35 +0200, Ján Tomko wrote:
> > > On Wed, Jun 06, 2018 at 05:30:15PM +0200, Andrea Bolognani wrote:
> > > > 
> > > >  Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1468422
> > > 
> > > Actually, the 'Resolves: ' part is pointless.
> > 
> > I happen to like it because it falls in neatly with the other
> > pseudo-headers we use in commit messages, but I will indeed not
> > lose any sleep if she ends up omitting it :)
> 
> If for some reason the software displaying the commit message does not
> make the link clickable, the 'Resolves:' part hurts usability.
> 
> Without it, I can triple-click to select the link and paste it into my
> browser.

I would argue what's hurting usability is software not making URLs
clickable in the first place.

-- 
Andrea Bolognani / Red Hat / Virtualization