[libvirt] [PATCH 06/10] util: Reorder parts of virresctrl

Ján Tomko jtomko at redhat.com
Thu Jun 7 22:27:23 UTC 2018


On Thu, Jun 07, 2018 at 03:54:27PM +0200, Martin Kletzander wrote:
>Move description of the purpose of the file before any definition.
>
>One empty line between related enum definitions.
>
>All typedefs before all structs.  This is exception from the usual, but not the
>only one, we already have something similar for some other structs.  This way we
>can move contents between structs and reorder some parts nicely without moving
>all definitions of one type before another one just so it's defined.
>
>Define all classes in one place.
>
>Have one initialization function for all classes in the file.
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
> src/util/virresctrl.c | 156 +++++++++++++++++++++---------------------
> 1 file changed, 79 insertions(+), 77 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180608/51e25368/attachment-0001.sig>


More information about the libvir-list mailing list