[libvirt] [PATCH 10/10] Move host cache handling from conf/ to util/

Ján Tomko jtomko at redhat.com
Thu Jun 7 22:50:33 UTC 2018


On Thu, Jun 07, 2018 at 03:54:31PM +0200, Martin Kletzander wrote:
>Introduce virCache{Info,Bank} as structures describing host cache information
>including the ways they can be managed by resctrl.  This has couple of
>advantages.  First and foremost the virResctrlAllocCreate() is no longer
>dependent on a data structure initialized in another part of the code and the
>data is automatically fresh.  This couldn't be done previously since the code
>initializing that was in conf/.  And it also makes more sense for functions that
>parse sysfs files to be in util/.  Last, but not least, the code doesn't
>duplicate any data or keep around stale information that needs to be
>recalculated anyway.
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
> src/conf/capabilities.c   | 397 +++++++++----------------------
> src/conf/capabilities.h   |  21 +-
> src/libvirt_private.syms  |   7 +-
> src/qemu/qemu_process.c   |  26 +-
> src/util/virresctrl.c     | 485 ++++++++++++++++++++++++++++++--------
> src/util/virresctrl.h     |  54 +++--
> src/util/virresctrlpriv.h |   4 +-
> tests/virresctrltest.c    |  18 +-
> 8 files changed, 560 insertions(+), 452 deletions(-)
>

I really hope this patch can be remade into a series.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180608/d0c42828/attachment-0001.sig>


More information about the libvir-list mailing list