[libvirt] [PATCH v2 1/5] docker: Commit initial Dockerfiles

Andrea Bolognani abologna at redhat.com
Fri Jun 15 10:09:39 UTC 2018


On Fri, 2018-06-15 at 10:05 +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 15, 2018 at 09:06:52AM +0200, Andrea Bolognani wrote:
> > libvirt.git feels like a sensible enough place to store these
> > files, especially considering that we've been storing pretty
> > much the same information in .travis.yml up until now; that
> > said, I don't love the idea of tracking what is ultimately
> > generated data, so I'm open to creating a separate, ad-hoc
> > repository (libvirt-dockerfiles.git?) instead.
> 
> They really should be just generated directly by a script in
> the libvirt-jenkins-ci repo, we don't need to check the
> generated files into git anywhere IMHO.

We *do* need to have the Dockerfiles committed *somewhere* for
Docker Hub automated builds to work.

> >  .docker/buildenv-centos-7.Dockerfile       |  70 ++++++++++++++
> >  .docker/buildenv-debian-8.Dockerfile       |  76 +++++++++++++++
> >  .docker/buildenv-debian-9.Dockerfile       |  78 ++++++++++++++++
> >  .docker/buildenv-debian-sid.Dockerfile     |  78 ++++++++++++++++
> >  .docker/buildenv-fedora-27.Dockerfile      |  78 ++++++++++++++++
> >  .docker/buildenv-fedora-28.Dockerfile      |  78 ++++++++++++++++
> >  .docker/buildenv-fedora-rawhide.Dockerfile | 102 +++++++++++++++++++++
> >  .docker/buildenv-ubuntu-16.Dockerfile      |  79 ++++++++++++++++
> >  .docker/buildenv-ubuntu-18.Dockerfile      |  79 ++++++++++++++++
> 
> Please put them in build-aux/docker, rather than a hidden
> directory.

Will do.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list