[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] set-lifecycle-action: add description of type and action



On 06/21/2018 01:28 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao gmail com>
> 
> In [1], <type> are described as "on_poweroff",
>    "on_reboot", "on_crash".
>    but we accept "poweroff", "reboot" and "crash".
> This patch adds docs about them.
> 
> [1]: https://libvirt.org/formatdomain.html#elementsEvents
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao gmail com>
> ---
>  tools/virsh.pod | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 7cb8c8a6e4..1b479f318d 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -2414,8 +2414,12 @@ the B<virsh dominfo> command.
>  =item B<set-lifecycle-action> I<domain> I<type> I<action>
>  [[I<--config>] [I<--live>] | [I<--current>]]
>  
> -Set the lifecycle I<action> for specified lifecycle I<type>. For the list of
> -lifecycle types and actions and possible combinations see the documentation at
> +Set the lifecycle I<action> for specified lifecycle I<type>.
> +The valid I<type> are "poweroff", "reboot" and "crash", each of them
> +allow valid I<action> are "destroy", "restart", "rename-restart", "preserve".
> +For I<type> "crash", additional actions "coredump-destroy"
> +and "coredump-restart" are supported. For the list of lifecycle types
> +and actions and possible combinations see the documentation at
>  L<https://libvirt.org/formatdomain.html#elementsEvents>.

I've reworded this block slightly and removed reference to the web page,
because we are enumerating types and actions here.

ACKed and pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]