[libvirt] update keycodemapdb submodule for 4.1.0 release

Martin Kletzander mkletzan at redhat.com
Fri Mar 2 11:48:53 UTC 2018


On Fri, Mar 02, 2018 at 10:45:35AM +0000, Daniel P. Berrangé wrote:
>On Fri, Mar 02, 2018 at 11:24:03AM +0100, Andrea Bolognani wrote:
>> On Fri, 2018-03-02 at 08:08 +0100, Martin Kletzander wrote:
>> > On Thu, Mar 01, 2018 at 04:52:09PM +0000, Daniel P. Berrangé wrote:
>> > > You show that we we missing CI coverage for python3 though, so we
>> > > should address that. We could make our Fedora Jenkins CI builds use py3,
>> > > along with one of our Travis scenarios, so we get a mix of py2&py3
>> > > coverage in both Jenkins & Travis.
>> >
>> > Do we?  I think the builds were switched so that we can run unit tests on
>> > virt-manager so now we have CI coverage for py2 as well as py3.
>>
>> We use both Python 2 and 3, but only for project that are themselves
>> implemented in Python (libvirt-python and virt-manager); what I
>> think Dan is referring to is that we only ever use Python 2 to call
>> keycodemapdb's own tools, so there's no Python 3 coverage for that.
>
>Yeah exactly - some bits of libvirt build process use python scripts and
>so we should test that under both.
>

Oh, thanks for the explanation, that makes sense.

>Regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180302/786eb584/attachment-0001.sig>


More information about the libvir-list mailing list