[libvirt] [PATCH v2 10/12] qemu_hotplug: Hotplug of reservations

[Ján Tomko]

On Wed, Feb 21, 2018 at 07:11:35PM +0100, Michal Privoznik wrote:
>Surprisingly, nothing special is happening here. If we are the
>first to use the managed helper then spawn it. If not, we're
>almost done.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++
> src/qemu/qemu_process.c | 38 +++++++++++++++++++++-----
> src/qemu/qemu_process.h |  7 +++++
> 3 files changed, 110 insertions(+), 7 deletions(-)
>
>diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
>index f28006e3c..2ebb68fbc 100644
>--- a/src/qemu/qemu_hotplug.c
>+++ b/src/qemu/qemu_hotplug.c
>@@ -348,6 +348,58 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver,
> }
>
>
>+static int
>+qemuBuildPRDefInfoProps(virDomainObjPtr vm,
>+                        virDomainDiskDefPtr disk,
>+                        virJSONValuePtr *prmgrProps,
>+                        const char **prAlias,
>+                        const char **prPath)
>+{
>+    qemuDomainObjPrivatePtr priv = vm->privateData;
>+    qemuDomainStorageSourcePrivatePtr srcPriv;
>+    virJSONValuePtr props = NULL;
>+    int ret = -1;
>+
>+    srcPriv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(disk->src);
>+
>+    *prmgrProps = NULL;
>+
>+    if (priv->prPid != (pid_t) -1 ||
>+        !srcPriv->prd ||
>+        !srcPriv->prd->alias)
>+        return 0;
>+

If !srcPriv->prd is NULL, you should not dereference it.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180302/06a18aad/attachment-0001.sig>