[libvirt] [PATCH 1/2] travis: move macOS before_install tasks into osx matrix entry

Andrea Bolognani abologna at redhat.com
Thu Mar 15 13:52:08 UTC 2018


On Thu, 2018-03-15 at 13:33 +0000, Daniel P. Berrangé wrote:
> The list of commands we're running for the before_install task
> is rather large. We have it all on one line because we're
> wrapping it all in a test against TRAVIS_OS_NAME env variable.
> 
> By moving it into the osx matrix entry we can remove the need
> for the conditional shell test. This lets us put each command
> on a separate line making the steps clear to understand.
> 
> Fortunately the 'before_install' task does not have the crazy
> behaviour whereby travis ignores errors and runs all commands
> regardless, like the 'script' task does. The first command
> failing will cause an immediate stop with error status.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  .travis.yml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list