[libvirt] [PATCH v1 4/7] qemu: Use correct bus type for input devices

[Farhan Ali]

On 03/16/2018 09:39 AM, John Ferlan wrote:
> 
> 
> On 03/08/2018 11:07 AM, Farhan Ali wrote:
>> commit 7210cef452db 'qemu: build command line for virtio input devices'
>> introduced an error, by checking if input bus type is
>> VIR_DOMAIN_DISK_BUS_VIRTIO.
>>
>> Fix it by using the correct bus type for input devices.
>>
>> Signed-off-by: Farhan Ali <alifm at linux.vnet.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>>   src/qemu/qemu_domain_address.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Nice catch!  Been around awhile too.  Doesn't look like there was a test
> to catch it either.

Hopefully my virtio ccw input tests should be enough to cover this?

> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> 
> John
> 
> (I'll push this along with patch 1 since it's separable)
> 


Thanks so much for all your review, I really appreciate all your 
feeedback :)