[libvirt] [PATCH 11/22] WmiClass: Don't share "versions" between instances

Daniel P. Berrangé berrange at redhat.com
Mon Mar 19 10:53:44 UTC 2018


On Sat, Mar 17, 2018 at 02:23:29PM +0000, Radostin Stoyanov wrote:
> Lists in Python are mutable and when used as a default value of a
> parameter for class constructor, its value will be shared between
> all class instances.
> 
> Example:
> 
> 	class Test:
> 	    def __init__(self, mylist=[]):
> 	        self.mylist = mylist
> 
> 	A = Test()
> 	B = Test()
> 	A.mylist.append("mylist from instance A")
> 	print(B.mylist) # Will print ['mylist from instance A']
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
> ---
>  src/hyperv/hyperv_wmi_generator.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list