[libvirt] [PATCH v2 0/7] Add support for video and input devices on S390

Ján Tomko jtomko at redhat.com
Thu Mar 22 19:32:31 UTC 2018


On Mon, Mar 19, 2018 at 02:35:28PM -0400, Farhan Ali wrote:
>Hi,
>
>This patch series adds Libvirt support for video and input devices
>for QEMU guests on S390. QEMU v2.11.0 added support for the
>virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw devices [2],
>which can be used as video and input devices respectively.
>
>Thanks
>Farhan
>
>[1] https://git.qemu.org/?p=qemu.git;a=commit;h=1f8ad88935f5cb5a2968909e392dbeee1a84b931
>[2] https://git.qemu.org/?p=qemu.git;a=commit;h=3382cf1fabbf722dce931846853dae711838e720
>
>ChangeLog
>---------
>v1 -> v2
>    - Split virtio-gpu-ccw capability (patch 1) and functionality (patch 2)
>      into 2 patches.
>
>    - Code changes per John's comments (patch 2).
>
>    - Split capability for input devices (patch 4) and functionality (patch 5)
>      into 2 patches.
>
>    - Modify news update as per John's suggestion (patch 7).
>
>
>Farhan Ali (7):
>  qemu: Introduce a new capability for virtio-gpu-ccw
>  qemu: Add support for virtio-gpu-ccw video device on S390
>  tests: Add test cases for virtio-gpu-ccw
>  qemu: Introduce capabilities for virtio input ccw devices
>  qemu: Add support for virtio input ccw devices
>  tests: Add test case for virtio input ccw devices
>  news: Update for virtio-gpu-ccw and virtio input ccw devices
>

Looks good to me. I have some nitpicks re: splitting the changes into
patches (which should also apply to the "input" part of the series)

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180322/5fb54fdb/attachment-0001.sig>


More information about the libvir-list mailing list