[libvirt] [PATCH 7/9] build: link setuid_rpc_client against JSON_LIBS

[Ján Tomko]

On Sat, Mar 31, 2018 at 11:05:38AM +0200, Peter Krempa wrote:
>On Thu, Mar 29, 2018 at 01:09:56 +0200, Ján Tomko wrote:
>> I have no idea how it builds without and switching to Jansson
>> exposes this.
>>
>> Signed-off-by: Ján Tomko <jtomko at redhat.com>
>> ---
>>  src/Makefile.am | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index fd09bfd17..2d2805818 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -743,6 +743,7 @@ libvirt_setuid_rpc_client_la_LDFLAGS = \
>>  		$(AM_LDFLAGS) \
>>  		$(LIBXML_LIBS) \
>>  		$(SECDRIVER_LIBS) \
>> +		$(JSON_LIBS) \
>
>Hmmm, isn't the setuid client supposed to be very minimal, and thus
>should not have dependencies on most libraries?
>
>Danpb (cc'd) might add some insight.

I see it now, I overlooked the use of WITH_YAJL in config-post.h:
config-post.h:# undef WITH_YAJL
config-post.h:# undef WITH_YAJL2

So even though the sources include virjson.c, it does not actually use
it.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180331/d71b7fa8/attachment-0001.sig>