[libvirt] [PATCH 14/35] qemu: block: Propagate 'legacy' parameter when formatting disk backing

John Ferlan jferlan at redhat.com
Wed May 2 19:02:32 UTC 2018



On 04/25/2018 11:15 AM, Peter Krempa wrote:
> The gluster protocol in qemu uses two styles, one of which is legacy and
> not covered by the QAPI schema. To allow using of the new style in the
> blockdev-add code, add a parameter for
> qemuBlockStorageSourceGetBackendProps which will switch between the two
> modes.

awkward to look at with line length limit used.  Maybe just start a new
paragraph with "To allow...".
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_block.c   | 11 +++++++----
>  src/qemu/qemu_block.h   |  3 ++-
>  src/qemu/qemu_command.c |  2 +-
>  tests/qemublocktest.c   |  2 +-
>  4 files changed, 11 insertions(+), 7 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list