[libvirt] [dbus PATCH v2 1/2] Change the default annotation for emitting changed properties to false

Pavel Hrdina phrdina at redhat.com
Fri May 4 12:28:26 UTC 2018


For some of these properties there is no libvirt event to detect the
change.  For some of the remaining properties we could somehow detect
the change but it would be a lot of code for nothing and it can be
added later if someone asks for that.

We could change the properties to methods but with the annotation we
can keep them as properties in order to allow to get them by single
D-Bus call.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

changes in v2:
    - annotation was moved to <interface> scope to make it the default
      one

 data/org.libvirt.Connect.xml | 1 +
 data/org.libvirt.Domain.xml  | 1 +
 data/org.libvirt.Network.xml | 1 +
 3 files changed, 3 insertions(+)

diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 3bda461..69bbc84 100644
--- a/data/org.libvirt.Connect.xml
+++ b/data/org.libvirt.Connect.xml
@@ -3,6 +3,7 @@
 
 <node name="/org/libvirt/connect">
   <interface name="org.libvirt.Connect">
+    <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
     <property name="Encrypted" type="b" access="read">
       <annotation name="org.gtk.GDBus.DocString"
         value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectIsEncrypted
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index eae6d97..089b896 100644
--- a/data/org.libvirt.Domain.xml
+++ b/data/org.libvirt.Domain.xml
@@ -3,6 +3,7 @@
 
 <node name="/org/libvirt/domain">
   <interface name="org.libvirt.Domain">
+    <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
     <property name="Active" type="b" access="read">
       <annotation name="org.gtk.GDBus.DocString"
         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsActive"/>
diff --git a/data/org.libvirt.Network.xml b/data/org.libvirt.Network.xml
index 81bf081..5b6823e 100644
--- a/data/org.libvirt.Network.xml
+++ b/data/org.libvirt.Network.xml
@@ -3,6 +3,7 @@
 
 <node name="/org/libvirt/network">
   <interface name="org.libvirt.Network">
+    <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
     <property name="Active" type="b" access="read">
       <annotation name="org.gtk.GDBus.DocString"
         value="See https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkIsActive"/>
-- 
2.14.3




More information about the libvir-list mailing list