[libvirt] [PATCH 00/13] Fix XML for persistent reservations and refactor

[Michal Privoznik]

On 05/14/2018 12:41 PM, Peter Krempa wrote:
> The XML design for the PR stuff is slightly weird so fix it and refactor
> the code so that it will be much easier to use it with the blockdev
> infrastructure.
> 
> Peter Krempa (13):
>   qemu: hotplug: Fix spacing around addition operator
>   qemu: alias: Allow passing alias of parent when generating PR manager
>     alias
>   qemu: command: Fix comment for qemuBuildPRManagerInfoProps
>   qemu: Move validation of PR manager support
>   util: storage: Drop pointless 'enabled' form PR definition
>   util: storage: Drop virStoragePRDefIsEnabled
>   util: storage: Allow passing <source> also for managed PR case
>   qemu: Assign managed PR path when preparing storage source
>   qemu: process: Change semantics of functions starting PR daemon
>   qemu: command: Move check whether PR manager object props need to be
>     built
>   conf: domain: Add helper to check whether a domain def requires use of
>     PR
>   util: storage: Store PR manager alias in the definition
>   qemu: hotplug: Replace qemuDomainDiskNeedRemovePR
> 
>  docs/formatdomain.html.in                          |  21 ++--
>  docs/schemas/storagecommon.rng                     |   3 -
>  src/conf/domain_conf.c                             |  21 ++++
>  src/conf/domain_conf.h                             |   3 +
>  src/libvirt_private.syms                           |   2 +-
>  src/qemu/qemu_alias.c                              |   4 +-
>  src/qemu/qemu_alias.h                              |   2 +-
>  src/qemu/qemu_command.c                            |  61 +++-------
>  src/qemu/qemu_command.h                            |   6 +-
>  src/qemu/qemu_domain.c                             |  66 ++++++++---
>  src/qemu/qemu_domain.h                             |   3 +-
>  src/qemu/qemu_hotplug.c                            |  83 +++-----------
>  src/qemu/qemu_process.c                            |  40 ++-----
>  src/qemu/qemu_process.h                            |   5 +-
>  src/util/virstoragefile.c                          | 124 ++++++++-------------
>  src/util/virstoragefile.h                          |   5 +-
>  tests/qemustatusxml2xmldata/modern-in.xml          |   4 +
>  .../disk-virtio-scsi-reservations.xml              |   4 +-
>  tests/qemuxml2xmltest.c                            |   2 +-
>  19 files changed, 191 insertions(+), 268 deletions(-)
> 

You have my ACK on the series, but I guess we'll need John's input on
12/13 because he was opposed to saving anything in status XML.

Michal