[libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
Andrea Bolognani
abologna at redhat.com
Wed May 16 09:20:26 UTC 2018
On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote:
> On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> > Even though the packages are technically only needed when
> > performing a MinGW build, it doesn't hurt to have them
> > installed when performing native build, and keeping the
> > native packages all in one place is cleaner.
> >
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > ---
> > guests/vars/projects/libosinfo+mingw.yml | 1 -
> > guests/vars/projects/libosinfo.yml | 1 +
> > guests/vars/projects/virt-viewer+mingw.yml | 1 -
> > guests/vars/projects/virt-viewer.yml | 1 +
> > 4 files changed, 2 insertions(+), 2 deletions(-)
>
> And I'm not sure about this one as well. Yes, it might make things
> cleaner that the mingw dependencies are only mingw-* packages but it's
> not correct. They are required only by the mingw build and not by the
> regular build so it will pollute systems where we don't run mingw
> builds.
I agree with your argument, to the point where I had basically
already acknowledged it in the commit message :)
Given how tiny the packages involved are, though, I think the
trade-off is worth it, especially in light of the stuff I
mentioned in the comments to the previous patch.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list