[libvirt] [tck PATCH] Use a pre-created MANIFEST file

Daniel P. Berrangé berrange at redhat.com
Wed May 16 10:01:45 UTC 2018


Using the MANIFEST.SKIP blacklist approach risks creating tarballs with
extra files mistakenly included if the working directory is not clean.
Switch to a pre-created MANIFEST file, since maintaining this short list
of files is not hard work.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 .gitignore         |   1 -
 MANIFEST           | 219 +++++++++++++++++++++++++++++++++++++++++++++
 MANIFEST.SKIP      |  19 ----
 prepare-release.sh |   1 -
 4 files changed, 219 insertions(+), 21 deletions(-)
 create mode 100644 MANIFEST
 delete mode 100644 MANIFEST.SKIP

diff --git a/.gitignore b/.gitignore
index cc1470e..ca3e424 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,7 +3,6 @@
 *.orig
 *~
 Build
-MANIFEST
 META.yml
 Makefile
 Makefile.PL
diff --git a/MANIFEST b/MANIFEST
new file mode 100644
index 0000000..b632328
--- /dev/null
+++ b/MANIFEST
@@ -0,0 +1,219 @@
+bin/libvirt-tck
+Build.PL
+conf/default.cfg
+docs/intro.pod
+docs/writing-tests.pod
+lib/Sys/Virt/TCK.pm
+lib/Sys/Virt/TCK/Capabilities.pm
+lib/Sys/Virt/TCK/DomainBuilder.pm
+lib/Sys/Virt/TCK/Hooks.pm
+lib/Sys/Virt/TCK/NetworkBuilder.pm
+lib/Sys/Virt/TCK/NetworkHelpers.pm
+lib/Sys/Virt/TCK/SELinux.pm
+lib/Sys/Virt/TCK/StoragePoolBuilder.pm
+lib/Sys/Virt/TCK/StorageVolBuilder.pm
+lib/Sys/Virt/TCK/TAP/XMLFormatter.pm
+lib/Sys/Virt/TCK/TAP/XMLFormatterSession.pm
+LICENSE
+Makefile.PL
+MANIFEST
+META.json
+META.yml
+perl-Sys-Virt-TCK.spec
+perl-Sys-Virt-TCK.spec.PL
+prepare-release.sh
+README
+scripts/domain/050-transient-lifecycle.t
+scripts/domain/051-transient-autostart.t
+scripts/domain/060-persistent-lifecycle.t
+scripts/domain/061-persistent-autostart.t
+scripts/domain/065-persistent-redefine.t
+scripts/domain/070-transient-to-persistent.t
+scripts/domain/080-unique-id-define.t
+scripts/domain/081-unique-id-create.t
+scripts/domain/082-unique-id-caching.t
+scripts/domain/090-invalid-ops-when-inactive.t
+scripts/domain/100-transient-save-restore.t
+scripts/domain/101-persistent-save-restore.t
+scripts/domain/102-broken-save-restore.t
+scripts/domain/103-blockdev-save-restore.t
+scripts/domain/110-memory-balloon.t
+scripts/domain/120-disks-stats.t
+scripts/domain/121-block-info.t
+scripts/domain/130-cpu-hotplug.t
+scripts/domain/180-interface-parameters.t
+scripts/domain/200-disk-hotplug.t
+scripts/domain/202-numa-set-parameters.t
+scripts/domain/205-disk-hotplug-ordering.t
+scripts/domain/207-disk-media-change.t
+scripts/domain/210-nic-hotplug.t
+scripts/domain/215-nic-hotplug-many.t
+scripts/domain/240-usb-host-hotplug.t
+scripts/domain/250-pci-host-hotplug.t
+scripts/domain/300-migration.t
+scripts/domain/301-migration-max-speed.t
+scripts/hooks/051-daemon-hook.t
+scripts/hooks/052-domain-hook.t
+scripts/networks/050-transient-lifecycle.t
+scripts/networks/051-transient-autostart.t
+scripts/networks/060-persistent-lifecycle.t
+scripts/networks/061-persistent-autostart.t
+scripts/networks/065-persistent-redefine.t
+scripts/networks/070-transient-to-persistent.t
+scripts/networks/080-unique-id-define.t
+scripts/networks/081-unique-id-create.t
+scripts/networks/082-unique-id-caching.t
+scripts/networks/090-invalid-ops-when-inactive.t
+scripts/networks/100-apply-verify-host.t
+scripts/networks/110-interface-change-transaction.t
+scripts/networks/networkApplyTest.sh
+scripts/networks/networkxml2hostout/tck-testnet-1.dat
+scripts/networks/networkxml2hostout/tck-testnet-1.post.dat
+scripts/networks/networkxml2hostout/tck-testnet-2.dat
+scripts/networks/networkxml2hostout/tck-testnet-2.post.dat
+scripts/networks/networkxml2hostout/tck-testnet-3.dat
+scripts/networks/networkxml2hostout/tck-testnet-3.post.dat
+scripts/networks/networkxml2xmlin/tck-testnet-1.xml
+scripts/networks/networkxml2xmlin/tck-testnet-2.xml
+scripts/networks/networkxml2xmlin/tck-testnet-3.xml
+scripts/nwfilter/050-apply-verify-host.t
+scripts/nwfilter/060-concurrency.t
+scripts/nwfilter/100-ping-still-working.t
+scripts/nwfilter/210-no-mac-spoofing.t
+scripts/nwfilter/220-no-ip-spoofing.t
+scripts/nwfilter/230-no-mac-broadcast.t
+scripts/nwfilter/240-no-arp-spoofing.t
+scripts/nwfilter/300-vsitype.t
+scripts/nwfilter/concurrency/chg-vm-filter.sh
+scripts/nwfilter/concurrency/start-destroy-vm.sh
+scripts/nwfilter/concurrency/tck-vm1-filter1.xml
+scripts/nwfilter/concurrency/tck-vm1-filter2.xml
+scripts/nwfilter/concurrency/tck-vm1.xml
+scripts/nwfilter/concurrency/tck-vm2-filter1.xml
+scripts/nwfilter/concurrency/tck-vm2-filter2.xml
+scripts/nwfilter/concurrency/tck-vm2.xml
+scripts/nwfilter/nwfilter2vmtest.sh
+scripts/nwfilter/nwfilter_concurrent.sh
+scripts/nwfilter/nwfilterxml2fwallout/ah-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/ah-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/all-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/all-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/arp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/comment-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/conntrack-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/esp-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/esp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/example-1.fwall
+scripts/nwfilter/nwfilterxml2fwallout/example-2.fwall
+scripts/nwfilter/nwfilterxml2fwallout/hex-data-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/icmp-direction-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/icmp-direction2-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/icmp-direction3-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/icmp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/icmpv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/igmp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/ip-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/ipset-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/ipt-no-macspoof-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/iter-test1.fwall
+scripts/nwfilter/nwfilterxml2fwallout/iter-test2.fwall
+scripts/nwfilter/nwfilterxml2fwallout/iter-test3.fwall
+scripts/nwfilter/nwfilterxml2fwallout/mac-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/rarp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/sctp-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/sctp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/stp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/target-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/target-test2.fwall
+scripts/nwfilter/nwfilterxml2fwallout/tcp-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/tcp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/testvm.fwall.dat
+scripts/nwfilter/nwfilterxml2fwallout/udp-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/udp-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/udplite-ipv6-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/udplite-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/vlan-test.fwall
+scripts/nwfilter/nwfilterxml2fwallout/zzz-ipset-cleanup.fwall
+scripts/nwfilter/nwfilterxml2xmlin/ah-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ah-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/all-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/all-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/arp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/comment-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/conntrack-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/esp-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/esp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/example-1.xml
+scripts/nwfilter/nwfilterxml2xmlin/example-2.xml
+scripts/nwfilter/nwfilterxml2xmlin/hex-data-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/icmp-direction-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/icmp-direction2-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/icmp-direction3-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/icmp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/icmpv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/igmp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ip-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ipset-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ipt-no-macspoof-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/iter-test1.xml
+scripts/nwfilter/nwfilterxml2xmlin/iter-test2.xml
+scripts/nwfilter/nwfilterxml2xmlin/iter-test3.xml
+scripts/nwfilter/nwfilterxml2xmlin/mac-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/rarp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ref-rule-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/ref-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/sctp-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/sctp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/stp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/target-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/target-test2.xml
+scripts/nwfilter/nwfilterxml2xmlin/tcp-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/tcp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/udp-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/udp-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/udplite-ipv6-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/udplite-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/vlan-test.xml
+scripts/nwfilter/nwfilterxml2xmlin/zzz-ipset-cleanup.xml
+scripts/nwfilter/README
+scripts/qemu/100-disk-encryption.t
+scripts/qemu/200-qcow2-single-backing-file.t
+scripts/qemu/205-qcow2-double-backing-file.t
+scripts/qemu/210-qcow2-auto-probing.t
+scripts/qemu/400-save-image-xml.t
+scripts/selinux/050-dynamic-relabel-yes.t
+scripts/selinux/055-dynamic-base-label.t
+scripts/selinux/100-static-relabel-no.t
+scripts/selinux/105-static-relabel-fail.t
+scripts/selinux/110-static-relabel-yes.t
+scripts/storage/050-transient-lifecycle.t
+scripts/storage/051-transient-autostart.t
+scripts/storage/060-persistent-lifecycle.t
+scripts/storage/061-persistent-autostart.t
+scripts/storage/065-persistent-redefine.t
+scripts/storage/070-transient-to-persistent.t
+scripts/storage/080-unique-id-define.t
+scripts/storage/081-unique-id-create.t
+scripts/storage/082-unique-id-caching.t
+scripts/storage/090-invalid-ops-when-inactive.t
+scripts/storage/100-create-vol-dir.t
+scripts/storage/110-disk-pool.t
+scripts/storage/120-get-ops.t
+scripts/storage/200-clone-vol-dir.t
+scripts/storage/250-vol-qcow2-backing-store.t
+scripts/storage/255-vol-qcow2-backing-store-auto.t
+scripts/storage/400-vol-download.t
+scripts/storage/405-vol-download-all.t
+scripts/storage/410-vol-download-nonblock.t
+scripts/storage/415-vol-upload.t
+scripts/storage/420-vol-upload-all.t
+scripts/storage/425-vol-upload-nonblock.t
+t/005-pod.t
+t/010-pod-coverage.t
+t/050-capabilities.t
+t/070-domain-builder.t
+t/080-network-builder.t
+t/090-storage-pool-builder.t
+t/100-storage-vol-builder.t
diff --git a/MANIFEST.SKIP b/MANIFEST.SKIP
deleted file mode 100644
index 8aa28aa..0000000
--- a/MANIFEST.SKIP
+++ /dev/null
@@ -1,19 +0,0 @@
-.*\.old
-.*\.bak
-Sys-Virt-TCK-
-blib
-\.hg
-.*~
-\.#.*
-#.*
-^Makefile$
-.*\.orig
-data/
-results/
-^Build$
-^_build/
-^\.git/
-^cover_db/
-^libvirt-tck/
-^MYMETA.yml$
-^MYMETA\.json$
diff --git a/prepare-release.sh b/prepare-release.sh
index 75777a8..ad29f16 100755
--- a/prepare-release.sh
+++ b/prepare-release.sh
@@ -21,7 +21,6 @@ rm -rf MANIFEST blib _build Build
 perl Build.PL install_base=$HOME/builder
 
 ./Build
-./Build manifest
 
 
 if [ -z "$USE_COVER" ]; then
-- 
2.17.0




More information about the libvir-list mailing list