[libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

[Daniel P. Berrangé]

On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote:
> We claim to be using Python 2 at the moment: however, we rely
> on crypt.mksalt(), which was introduced in Python 3 and has
> only been backported to Python 2 in RHEL and Fedora, so the
> script will only work on those operating systems.
> 
> We could move to Python 3, but the CI nodes are running on a
> CentOS 7 machine, where it can't be installed without pulling
> in third-party repositories and dealing with awkward naming;
> moreover, Ansible itself is still tied to Python 2, so we
> would be requiring both to be available.
> 
> Perl to the rescue! The script ends up being only marginally
> more verbose and obscure as a result, the indentation is
> significantly better, and it should finally run on pretty
> much any platform.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/lcitool | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|