[libvirt] [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

Peter Krempa pkrempa at redhat.com
Wed May 23 13:04:47 UTC 2018


On Tue, May 22, 2018 at 15:24:06 +0200, Ján Tomko wrote:
> On Tue, May 22, 2018 at 02:35:44PM +0200, Peter Krempa wrote:
> > Monitor is now JSON only. Drop the old cruft.
> > 
> 
> In theory, you should still be able to get a domain with a text monitor
> via qemu-attach.
> 
> In practice, attaching to such domains seems pointless - if we don't
> support starting them, touching their mointor might just break them.

I can leave the part of the macro that checks whether the monitor is
JSON still in. That way it will at least report sane errors.

> Maybe we should drop qemu-attach as well?

I hope so, but it should be probably done separately.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180523/239b5205/attachment-0001.sig>


More information about the libvir-list mailing list