[libvirt] [PATCH 04/22] virsh: Enhance documentation of cpu-models command

Kashyap Chamarthy kchamart at redhat.com
Wed May 23 14:53:37 UTC 2018


On Wed, May 23, 2018 at 02:43:23PM +0200, Jiri Denemark wrote:
> On Wed, May 23, 2018 at 13:08:51 +0200, Kashyap Chamarthy wrote:
> > On Wed, May 16, 2018 at 10:39:23AM +0200, Jiri Denemark wrote:
> > > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > > ---
> > >  tools/virsh.pod | 8 +++++++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)

[...]

> > > +Moreover, for some architectures libvirt does not know any CPU models and
> > > +the usable CPU models are only limited by the hypervisor. 
> > 
> > Wonder if it is worth adding a small example for the above.
> 
> An example for what exactly?

I meant an example of a usable CPU model that libvirt doesn't know for
the said architecture(s).  Maybe it's not worth it; not quite sure.

> > > This command will
> > > +print that all CPU models are accepted for these architectures.
> > 
> > s/CPU models are accepted/CPU models that are accepted/
> 
> It's certainly possible my wording was not perfect, but this change
> would make it wrong.

Err, sorry, I misread that sentence; please disregard the above.

[...]

-- 
/kashyap




More information about the libvir-list mailing list