[libvirt] [PATCH 02/22] virsh: Extract common code from cmdCPU{Compare, Baseline}

Ján Tomko jtomko at redhat.com
Thu May 24 13:56:58 UTC 2018


On Wed, May 16, 2018 at 10:39:21AM +0200, Jiri Denemark wrote:
>Both cpu-compare and cpu-baseline commands accept more that just CPU
>definition XML(s). For users' convenience they are able to extract the
>CPU definition(s) even from domain XML or capabilities XML. The main
>differences between the two commands is in the number of CPU definitions
>they expect: cpu-compare wants only one CPU definition while
>cpu-baseline expects one or more CPUs.
>
>The extracted code forms a new vshExtractCPUDefXML function.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> tools/virsh-host.c | 160 +++++++++++++++++++++------------------------
> 1 file changed, 75 insertions(+), 85 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180524/65f1d981/attachment-0001.sig>


More information about the libvir-list mailing list