[libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio fidencio at redhat.com
Fri May 25 17:17:43 UTC 2018


On Fri, May 25, 2018 at 3:27 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> This patchset finishes the conversion to virConfGetValue* functions,
> started by Daniel Berrange a few months ago.
>
> Please, mind that although we could make virConfGetValue* functions more
> generic in order to support numbers and booleans as strings, that
> doesn't seem the safest path to take. The side-effect of this is that we
> will have to live with some specific code doing that as part of vmx and
> xen_common.

Self-nack! In the third patch I'm leaking some lists.
I'll submit a v2.

>
> Fabiano Fidêncio (3):
>   xen_vm: convert to typesafe virConf accessors
>   vmx: convert to typesafe virConf accessors
>   xen_common: convert to typesafe virConf accessors
>
>  src/vmx/vmx.c              | 197 +++++-------
>  src/xenconfig/xen_common.c | 631 ++++++++++++++++++-------------------
>  src/xenconfig/xen_xm.c     | 268 ++++++++--------
>  3 files changed, 504 insertions(+), 592 deletions(-)
>
> --
> 2.17.0
>




More information about the libvir-list mailing list