[libvirt] [PATCH] virtlockd: acquire locks on re-exec

[Jim Fehlig]

On 05/28/2018 04:34 AM, Matthew Richardson wrote:
>> Locks held by virtlockd are dropped on re-exec.
>>
>> virtlockd       94306 POSIX 5.4G WRITE 0     0   0 /tmp/test.qcow2
>> virtlockd       94306 POSIX   5B WRITE 0     0   0 /run/virtlockd.pid
>> virtlockd       94306 POSIX   5B WRITE 0     0   0 /run/virtlockd.pid
>>
>> Acquire locks in PostExecRestart code path.
>>
>> Signed-off-by: Jim Fehlig <jfehlig at xxxxxxxx>
> 
> I've just encountered this same unexpected behaviour (currently on RHEL7
> box running libvirt 3.2), and found this thread while searching for a
> bug report.
> 
> Has this patch been accepted, or the issue fixed in a later release? I
> notice there was some confusion in the conversation following as to the
> cause of this issue/the fix for it.

The problem with losing fcntl locks on execve was worked around in libvirt with 
this patch series (included in libvirt 4.2.0)

https://www.redhat.com/archives/libvir-list/2018-March/msg00298.html

> If not, is there a bug open against this which I can follow/comment on?

There's an open bug to track the lost locks

https://bugzilla.redhat.com/show_bug.cgi?id=1552621

Regards,
Jim