[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v7 01/14] conf: Add definitions for 'uid' and 'fid' PCI address attributes



On Fri, 2018-10-19 at 11:40 +0800, Yi Min Zhao wrote:
>  struct _virPCIDeviceAddress {
>      unsigned int domain;
>      unsigned int bus;
>      unsigned int slot;
>      unsigned int function;
>      int multi; /* virTristateSwitch */
> +    virZPCIDeviceAddress zpci;

Laine pointed out that it's weird that 'zpci' is not added in the
same patch as 'extFlags', and more specifically that the former is
introduced before the latter.

I believe I pointed out the same thing at some point, or at least
I though about doing so :) Now that it's two people noticing the
same, I guess it would be nice to address it. Shouldn't be hard at
all... Can you please take care of it?

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]