[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v7 08/14] conf: Introduce parser, formatter for uid and fid



On Fri, 2018-10-19 at 11:40 +0800, Yi Min Zhao wrote:
> This patch introduces new XML parser/formatter functions. Uid is
> 16-bit and non-zero. Fid is 32-bit. They are the two attributes of zpci
> which is introduced as PCI address element. Zpci element is parsed and
> formatted along with PCI address. And add the related test cases.
> 
> Signed-off-by: Yi Min Zhao <zyimin linux ibm com>
> Reviewed-by: Boris Fiuczynski <fiuczy linux ibm com>
> Reviewed-by: Stefan Zimmermann <stzi linux ibm com>
> Reviewed-by: Bjoern Walk <bwalk linux ibm com>
> Reviewed-by: Ján Tomko <jtomko redhat com>
> ---
>  docs/schemas/basictypes.rng                   | 27 ++++++++++
>  docs/schemas/domaincommon.rng                 |  1 +
>  src/conf/device_conf.c                        | 53 +++++++++++++++++++
>  src/conf/domain_addr.c                        |  3 ++
>  src/conf/domain_conf.c                        | 12 ++++-
>  src/libvirt_private.syms                      |  2 +
>  src/util/virpci.c                             | 26 +++++++++
>  src/util/virpci.h                             |  6 +++
>  .../disk-virtio-s390-zpci.args                | 25 +++++++++
>  .../disk-virtio-s390-zpci.xml                 | 19 +++++++
>  tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 23 ++++++++
>  tests/qemuxml2argvdata/hostdev-vfio-zpci.xml  | 21 ++++++++
>  tests/qemuxml2argvtest.c                      |  7 +++
>  .../disk-virtio-s390-zpci.xml                 | 31 +++++++++++
>  .../qemuxml2xmloutdata/hostdev-vfio-zpci.xml  | 32 +++++++++++
>  tests/qemuxml2xmltest.c                       |  6 +++
>  16 files changed, 293 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.args
>  create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.xml
>  create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci.args
>  create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci.xml
>  create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-s390-zpci.xml
>  create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-zpci.xml

Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]