[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 6/8] qemu: implement usb hub device hotplug





On Tue, Nov 6, 2018 at 6:34 AM John Ferlan <jferlan redhat com> wrote:
$SUBJ:

s/implement/Implement

On 10/12/18 4:50 AM, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1375423

Add the infrastructure to allow a USB Hub device to be hotplugged.

>
> Signed-off-by: Han Han <hhan redhat com>
> ---
>  src/qemu/qemu_driver.c  |  9 ++++++-
>  src/qemu/qemu_hotplug.c | 58 +++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_hotplug.h |  8 ++++++
>  3 files changed, 74 insertions(+), 1 deletion(-)
>

[...]

> diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h
> index 0297e42a98..444333c4df 100644
> --- a/src/qemu/qemu_hotplug.h
> +++ b/src/qemu/qemu_hotplug.h
> @@ -135,10 +135,18 @@ int qemuDomainAttachInputDevice(virQEMUDriverPtr driver,
>                                  virDomainObjPtr vm,
>                                  virDomainInputDefPtr input);

> +int qemuDomainAttachHubDevice(virQEMUDriverPtr driver,
> +                          virDomainObjPtr vm,
> +                          virDomainHubDefPtr hub);
> +
>  int qemuDomainAttachVsockDevice(virQEMUDriverPtr driver,
>                                  virDomainObjPtr vm,
>                                  virDomainVsockDefPtr vsock);

> +int qemuDomainAttachInputDevice(virQEMUDriverPtr driver,
> +                                virDomainObjPtr vm,
> +                                virDomainInputDefPtr input);
> +

cut-n-paste error perhaps? I'll remove before pushing though...
Sorry for the silly mistake... I will remove it in new patch series.

Reviewed-by: John Ferlan <jferlan redhat com>

John


>  int qemuDomainAttachLease(virQEMUDriverPtr driver,
>                            virDomainObjPtr vm,
>                            virDomainLeaseDefPtr lease);
>


--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan redhat com
Phone: +861065339333

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]