[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] qemu: caps: add drive.qcow2.l2-cache-size



On Thu, Nov 01, 2018 at 14:32:22 +0300, Nikolay Shirokovskiy wrote:

Missing description of what the capability bit detects in the commit
message.

> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy virtuozzo com>
> ---
>  src/qemu/qemu_capabilities.c                       | 3 +++
>  src/qemu/qemu_capabilities.h                       | 1 +

[...]

>  28 files changed, 30 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index e228f52..7d42254 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -508,6 +508,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
>                /* 315 */
>                "vfio-pci.display",
>                "blockdev",
> +              "drive.qcow2.l2-cache-size",
>      );
>  
>  
> @@ -1234,6 +1235,8 @@ static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = {
>      { "blockdev-add/arg-type/+vxhs", QEMU_CAPS_VXHS},
>      { "blockdev-add/arg-type/+iscsi/password-secret", QEMU_CAPS_ISCSI_PASSWORD_SECRET },
>      { "blockdev-add/arg-type/+qcow2/encrypt/+luks/key-secret", QEMU_CAPS_QCOW2_LUKS },
> +    { "blockdev-add/arg-type/options/+qcow2/l2-cache-size", QEMU_CAPS_DRIVE_QCOW2_L2_CACHE_SIZE},

This can be dropped ...

> +    { "blockdev-add/arg-type/+qcow2/l2-cache-size", QEMU_CAPS_DRIVE_QCOW2_L2_CACHE_SIZE},

... and this needs to be modified since the cache behaves differently
as pointed out in 3/3.

>      { "nbd-server-start/arg-type/tls-creds", QEMU_CAPS_NBD_TLS },
>      { "screendump/arg-type/device", QEMU_CAPS_SCREENDUMP_DEVICE },
>      { "block-commit/arg-type/*top",  QEMU_CAPS_ACTIVE_COMMIT },

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]