[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] conf: Forbid some nonsensical combinations under <memoryBackend>




On 10/15/18 8:39 AM, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (2):
>   conf: Forbid hugepages and <source type='file'/>
>   conf: Forbid hugepages and <allocation mode="ondemand"/>
> 
>  src/conf/domain_conf.c                        | 25 +++++++++++++++++--
>  .../qemuxml2argvdata/hugepages-memaccess2.xml |  1 -
>  2 files changed, 23 insertions(+), 3 deletions(-)
> 

It wasn't clear from the existing review comment whether you were going
to update; however, the one thing I'd point out is that by changing Post
Parse processing to add some XML check/condition that was previously
accepted could theoretically cause a guest to disappear after libvirtd
restart, right?

Thus shouldn't the changes go in the Validate processing?

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]