[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 02/22] qemu_process: Use qemuProcess prefix



On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> s/virQEMUCapsInitQMPCommand/qemuProcess/
> 
> No functionality change.
> 
> Use appropriate prefix in moved code.
> 
> Signed-off-by: Chris Venteicher <cventeic redhat com>
> ---
>  src/qemu/qemu_capabilities.c | 14 +++++++-------
>  src/qemu/qemu_process.c      | 28 ++++++++++++++--------------
>  src/qemu/qemu_process.h      | 22 +++++++++++-----------
>  3 files changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 0f70fdf46d..f6d97648ce 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -4219,15 +4219,15 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps,
>                     gid_t runGid,
>                     char **qmperr)
>  {
> -    virQEMUCapsInitQMPCommandPtr cmd = NULL;
> +    qemuProcessPtr cmd = NULL;
>      int ret = -1;
>      int rc;
>  
> -    if (!(cmd = virQEMUCapsInitQMPCommandNew(qemuCaps->binary, libDir,
> -                                             runUid, runGid, qmperr)))
> +    if (!(proc = qemuProcessNew(qemuCaps->binary, libDir,

Ooops, this needs to stay @cmd. The idea is that after every single
commit one has to be able to 'make all syntax-check check'.

> +                                runUid, runGid, qmperr)))
>          goto cleanup;
>  

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]