[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] conf: qemu: add support for Hyper-V PV IPIs



On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows

s/Qemu-3.1/QEMU 3.1/

[...]
> +        <tr>
> +          <td>ipi</td>
> +          <td>Enable PV IPI support</td>
> +          <td> on, off</td>

No whitespace before "on", please.

Pre-existing: several entires in the section have the same issue,
feel free to fix them (in a separate patch).

> +          <td><span class="since">4.10.0 (QEMU 3.1)</span></td>

Again pre-existing: what does the first version number refer to? It
would be nice to have it spelled out.

[...]
> @@ -172,7 +172,8 @@ VIR_ENUM_IMPL(virDomainHyperv, VIR_DOMAIN_HYPERV_LAST,
>                "vendor_id",
>                "frequencies",
>                "reenlightenment",
> -              "tlbflush")
> +              "tlbflush",
> +              "ipi")

Since you're touching this anyway, you can take the opportunity to
rewrite it as

  VIR_ENUM_IMPL(virDomainHyperv, VIR_DOMAIN_HYPERV_LAST,
    ...
    "tlbflush",
    "ipi",
  );

so that the next patch and any subsequent ones will look nicer.

[...]
> +KVM_FEATURE_DEF(VIR_CPU_x86_KVM_HV_IPI,
> +                0x40000004, 0x00000400);

I'm going to assume the magic numbers here are correct :)

Everything else looks good.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]