[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v8 00/14] PCI passthrough support on s390



On Tue, Nov 13, 2018 at 03:35:43PM +0100, Andrea Bolognani wrote:
> On Thu, 2018-11-08 at 19:00 +0800, Yi Min Zhao wrote:
> > Abstract
> > ========
> > The PCI representation in QEMU has been extended for S390
> > allowing configuration of zPCI attributes like uid (user-defined
> > identifier) and fid (PCI function identifier).
> > The details can be found here:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07262.html
> > 
> > To support the new zPCI feature of the S390 platform, a new element of
> > PCI address is introduced. It has two optional attributes, @uid and
> > @fid. For example:
> >   <hostdev mode='subsystem' type='pci'>
> >     <driver name='vfio'/>
> >     <source>
> >       <address domain='0x0001' bus='0x00' slot='0x00' function='0x0'/>
> >     </source>
> >     <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'>
> >       <zpci uid='0x0003' fid='0x00000027'/>
> >     </address>
> >   </hostdev>
> > 
> > If they are defined by the user, unique values within the guest domain
> > must be used. If they are not specified and the architecture requires
> > them, they are automatically generated with non-conflicting values.
> > 
> > zPCI address as an extension of the PCI address are stored in a new
> > structure 'virZPCIDeviceAddress' which is a member of common PCI
> > Address structure. Additionally, two hashtables are used for assignment
> > and reservation of zPCI uid/fid.
> > 
> > In support of extending the PCI address, a new PCI address extension flag is
> > introduced. This extension flag allows is not only dedicated for the S390
> > platform but also other architectures needing certain extensions to PCI
> > address space.
> 
> I have now provided R-b for the only patch that was still missing it,
> and as far as I'm concerned the series is ready to be pushed.
> 
> Dan, do you have any remaining concerns about the XML syntax, or can
> I go ahead and push?

Honestly, I still don't much like it & would prefer zpci as a top level
address type, but the consensus is in favour of this patch series'
approach, so don't consider me a blocker. Feel free to push if you
think it is ready.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]