[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 03/15] qemu_tpm: Pass virDomainObjPtr instead of virDomainDefPtr




On 11/14/18 7:44 AM, Michal Privoznik wrote:
> The TPM code currently accepts pointer to a domain definition.
> This is okay for now, but in near future the security driver APIs
> it calls will require domain object. Therefore, change the TPM
> code to accept the domain object pointer.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_extdevice.c | 16 ++++++++--------
>  src/qemu/qemu_extdevice.h |  4 ++--
>  src/qemu/qemu_process.c   |  6 +++---
>  src/qemu/qemu_security.c  | 14 +++++++-------
>  src/qemu/qemu_security.h  |  4 ++--
>  src/qemu/qemu_tpm.c       | 24 ++++++++++++------------
>  src/qemu/qemu_tpm.h       |  4 ++--
>  7 files changed, 36 insertions(+), 36 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John

At one time I really hoped we could make the obj's transparent to
callers and force usage of virDomainObjGetDef, but I know that's a sheer
impossibility!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]