[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] conf: Fix error flow in virDomainPCIAddressEnsureAddr()



On Fri, Nov 16, 2018 at 05:21:29PM +0100, Andrea Bolognani wrote:
> This avoids setting 'ret' multiple times, which will result
> in errors being masked if the first operation fails but the
> second one succeeds.
> 
> Introduced-by: f183b87fc1dbcc6446ac3c1cef9cdd345b9725fb
> Spotted-by: Coverity
> Reported-by: John Ferlan <jferlan redhat com>
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  src/conf/domain_addr.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]