[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v8 07/14] conf: use virXMLFormatElement() in virDomainDeviceInfoFormat()



On 11/16/18 5:23 PM, Andrea Bolognani wrote:
On Fri, 2018-11-16 at 07:43 -0500, John Ferlan wrote:
On 11/8/18 6:00 AM, Yi Min Zhao wrote:
[...]
@@ -6556,7 +6558,9 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
          break;
      }
- virBufferAddLit(buf, "/>\n");
+    virXMLFormatElement(buf, "address", &attrBuf, NULL);

Coverity complains this morning that this doesn't check the status of
the call to virXMLFormatElement like is done for other callers in this
module.

Both this issue and the other one you reported are addressed by

   https://www.redhat.com/archives/libvir-list/2018-November/msg00685.html

Andrea,
thanks for fixing the two coverity issues.

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]