[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 00/22] Move process code to qemu_process

On Sun, Nov 11, 2018 at 13:59:08 -0600, Chris Venteicher wrote:
> Make process code usable outside qemu_capabilities by moving code
> from qemu_capabilities to qemu_process and exposing public functions.
> The process code is used to activate a non domain QEMU process for QMP
> message exchanges.
> This patch set modifies capabilities to use the new public functions.
> --
> The process code is being decoupled from qemu_capabilities now to
> support hypervisor baseline and comparison using QMP commands.
> This patch set was originally submitted as part of the baseline patch set:
>   [libvirt] [PATCH v4 00/37] BaselineHypervisorCPU using QEMU QMP exchanges
>   https://www.redhat.com/archives/libvir-list/2018-November/msg00091.html
> The baseline and comparison requirements are described here:
> https://bugzilla.redhat.com/show_bug.cgi?id=1511999
> https://bugzilla.redhat.com/show_bug.cgi?id=1511996
> I am extracting and resubmitting just the process changes as a stand
> alone series to try to make review easier.

I know this was suggested by Colin, but it actually makes review harder,
because there's no code which would make use of the new functions and
thus there seems to be no reason for refactoring. Not to mention that
seeing real usage of a new function influences its design.

Although it surely makes sense do have the refactoring patches in the
beginning of the series rather than mixing them with the rest of the new

I applied both this series and your former v4 series, rebased the v4 one
on top of this RFC and now I'm reviewing the result. So please, keep
sending just one series with all the patches.

During the review, I'm not going to repeat anything already mentioned by
Michal, unless I want to say something more about it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]