[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error



On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote:
> During qemuConnectGetAllDomainStats if qemuDomainGetStats causes
> a failure, then when collecting more than one domain's worth of
> statistics the loop in virDomainStatsRecordListFree would call
> virDomainFree which would call virResetLastError effectively wiping

A (probably) silly question, but why do we have to call virResetLastError as
within virDomainFree in the first place?

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]